4 Replies Latest reply on Aug 31, 2012 3:15 PM by jfrenetic

@CleanupUsingScript with phase=NONE?

jfrenetic Aug 30, 2012 6:32 PM

OK, this is funny

Here is my test:

@Test
@CleanupUsingScript(phase = TestExecutionPhase.NONE)
@DataSource("jdbc/TestPool")
@UsingDataSet("init.xml")
public void testStuff() { }

This is what I get when running it:

org.jboss.arquillian.persistence.exception.InvalidResourceLocation: Unable to locate cleanup-com.example.arqtest.SimpleTest#testStuff.sql. File does not exist also in default location scripts/
          at org.jboss.arquillian.persistence.metadata.provider.ResourceProvider.determineLocation(ResourceProvider.java:165)
          at org.jboss.arquillian.persistence.metadata.provider.SqlScriptProvider.createDescriptor(SqlScriptProvider.java:63)
          at org.jboss.arquillian.persistence.metadata.provider.SqlScriptProvider.createDescriptor(SqlScriptProvider.java:35)
          at org.jboss.arquillian.persistence.metadata.provider.ResourceProvider.getDescriptorsDefinedFor(ResourceProvider.java:87)
          at org.jboss.arquillian.persistence.metadata.provider.ResourceProvider.getDescriptors(ResourceProvider.java:76)
          at org.jboss.arquillian.persistence.deployment.PersistenceExtensionDynamicDependencyAppender.fetchAllDataResources(PersistenceExtensionDynamicDependencyAppender.java:98)

I know, it doesn't make sense using @CleanupUsingScript with phase=TestExecutionPhase.NONE, but I guess the exception is wrong in this case, and should be easy to fix

1. Re: @CleanupUsingScript with phase=NONE?

bmajsak Aug 31, 2012 3:12 AM (in response to jfrenetic)

Ah that's indeed funny But on the other hand semantically it's not really correct - you should not be able to use NONE in this case. Maybe I should rework this annotation to not have phase as attribute but somethring more like before / after scripts.
The thing here is that if you don't specify file explicitily it will assume the name based on the rules explained in the javadoc, so in this case it's looking for the script named cleanup-[full.class.name]#testName.sql
Actions
2. Re: @CleanupUsingScript with phase=NONE?

jfrenetic Aug 31, 2012 3:24 AM (in response to bmajsak)

Yeah, I also think that it's not semantically correct Should I open a JIRA for that?
Actions
3. Re: @CleanupUsingScript with phase=NONE?

bmajsak Aug 31, 2012 3:43 AM (in response to jfrenetic)

Feel free
Actions
4. Re: @CleanupUsingScript with phase=NONE?

jfrenetic Aug 31, 2012 3:15 PM (in response to bmajsak)

Here we go: ARQ-1086
Actions

Go to original post