4 Replies Latest reply: Jun 3, 2010 12:18 PM by Sidd Muthiah RSS

feedback on JBAS-7195 (WrappedConnection.checkTransactionStatus throws exception when transaction is marked for roll back)

Scott Marlow Master

Any arguments against altering the change made for JBAS-5082 to relax TxConnectionManager.checkTransactionActive() as follows?

 

Change from:

{code}

  if (status != Status.STATUS_ACTIVE && status != Status.STATUS_PREPARING && status != Status.STATUS_PREPARED && status != Status.STATUS_COMMITTING)
    throw new RollbackException("Transaction " + tx + " cannot proceed " + TxUtils.getStatusAsString(status));

{code}

 

Change to:

 

{code}

  if (status != Status.STATUS_ACTIVE && status != Status.STATUS_PREPARING && status != Status.STATUS_PREPARED && status != Status.STATUS_COMMITTING && status != Status.STATUS_MARKED_ROLLBACK)
    throw new RollbackException("Transaction " + tx + " cannot proceed " + TxUtils.getStatusAsString(status));

{code}