3 Replies Latest reply on May 9, 2013 2:56 PM by calca

    Concurrency issue with LocalTaskService

    jkranes

      I am running into a concurrency issue in my JBPM 5.4 application.  At first I thought it was related to thread safety of the StatefulKnowledgeSession issue discussed elsewhere, but I am able to recreate the issue without any session at all.

       

      I am using the Spring JtaTransactionManager with annotated transaction boundaries, with MySQL, and running on AS 7.1.1.

       

      The Spring configuration looks like this:

       

       


      {code:xml}<jee:jndi-lookup id="emf" jndi-name="persistence/myEmf"/>

      <bean id="sel" class="org.drools.SystemEventListenerFactory"


      factory-method="getSystemEventListener" />

      <bean id="jbpmTaskService" class="org.jbpm.task.service.TaskService"


      c:emf-ref="emf" c:systemEventListener-ref="sel" />

      <bean id="localTaskService" class="org.jbpm.task.service.local.LocalTaskService"

      c:taskService-ref="jbpmTaskService" />

      <bean id="jpaDialect" class="org.springframework.orm.jpa.vendor.HibernateJpaDialect" />

      <bean id="txManager" class="org.springframework.transaction.jta.JtaTransactionManager" />

      <tx:annotation-driven transaction-manager="txManager" />{code}

       

       

      And the code triggering the problem is this:

       

       

      {code}

      List<TaskSummary> tasks = localTaskService.getTasksAssignedAsPotentialOwner(assignee, "en-UK"));

             for (TaskSummary summary: tasks){

                   // ...

                      org.jbpm.task.Task t = localTaskService.getTask(summary.getId());

                   // ....

                  }

              }

      {code}

       

      Note that this code is annotated as @Transactional

       

      If I call this code from a single thread or inside a synchronized block I have no problems.  If I call it from multiple concurrent threads, I consistently trigger the error:

       

      java.lang.IllegalStateException: Trying to return an unknown connection2! org.jboss.jca.adapters.jdbc.jdk6.WrappedConnectionJDK6@2a77a3c4

       

      The trigger seems to be the inner call to the localTaskService.  With just the outer call I have no problems. 

       

      Googling this error, it seems this was a common problem with older hibernate versions (2.x) but I did not find any references to people seeing it for hibernate 4.x.

       

      Any ideas?

       

      Thanks,

       

      Jon

        • 1. Re: Concurrency issue with LocalTaskService
          calca

          I had problems with LocalTaskService. I think the problem is that LocalTaskService is not thread safe.. I solved problems just creating a new LocalTaskService per requrest.

           

          Thanks

           

          Demian

          • 2. Re: Concurrency issue with LocalTaskService
            jkranes

            Yes, creating a new LocalTaskService instance inside each method where I use it does seem to do the trick, so it does seem to be the source of the concurrency error.  At least based on some quick testing, I seem to be able to construct it using a singleton instance of org.jbpm.task.service.TaskService.  Next step is to optimize a bit by creating only one per request as you suggested.

             

            Any other similar issues I should be looking out for?  I am still trying to figure out a good workaround for the StatefulKnowledgeSession thread safety issue.  I'm a bit concerned that all these thread safety issues, as the app I am working on is expected to eventually scale up fairly high.

             

            Thanks,

             

            Jon

            • 3. Re: Concurrency issue with LocalTaskService
              calca

              Well, this was the last concurrency issue I had .

              And I also know that the jBPM team is aware of the issue so it should be solevd in next release (probably jBPM6).

               

              Thanks!