2 Replies Latest reply on Jul 23, 2012 9:46 PM by igarashitm

Transaction Policy: Stage2

igarashitm Jul 20, 2012 11:09 PM

Now I'm struggling with https://issues.jboss.org/browse/SWITCHYARD-748

Code

https://github.com/igarashitm/core/commit/6b61621a20bcbfde1c3ed192909a4286a34b4fbc

What I have done so far

Added 3 more intents according to SCA Policy spec - "managedTransaction.global", "managedTransaction.local" and "noManagedTransaction"
Added 1 original intent - "propagatesOrCreatesTransaction"
Clarified the runtime-specific behavior (the behavior when policy is absent. see table below)

Transaction behavior

Interaction Policy	Implementation Policy	Transaction Provided	Result
<absent>	<any>	<any>	Propagates transaction if exists, otherwise does nothing
propagatesTransaction	managedTransaction.global or <absent>	yes	Propagates transaction
propagatesTransaction	managedTransaction.global or <absent>	no	Raise an error (unlike spec)
propagatesTransaction	managedTransaction.local or noManagedTransaction	<any>	Raise an error
propagatesOrCreatesTransaction	managedTransaction.global or <absent>	yes	Propagates transaction
propagatesOrCreatesTransaction	managedTransaction.global or <absent>	no	Creates new transaction, and completes it after invocation
propagatesOrCreatesTransaction	managedTransaction.local or noManagedTransaction	<any>	Raise an error
suspendsTransaction	managedTransaction.global	yes	Suspends existing transaction and creates new one. After invocation, complete the transaction created, and then resume the original transaction
suspendsTransaction	managedTransaction.global	no	Creates new transaction, and completes it after invocation
suspendsTransaction	managedTransaction.local	yes	Suspends existing transaction and creates new one. After invocation, complete the transaction created, and then resume the original transaction
suspendsTransaction	managedTransaction.local	no	Creates new transaction, and completes it after invocation
suspendsTransaction	noManagedTransaction or <absent>	yes	Suspends existing transaction and resumes it after invocation
suspendsTransaction	noManagedTransaction or <absent>	no	Does nothing

What should be done

In the case of managedTransaction.local, we need to guarantee that the service invocation doesn't propagate transaction to the outbound
Implement reference interaction policy processing
Create demo application

I'm looking forward to seeing your advice

Thanks,

Tomo

1. Re: Transaction Policy: Stage2

kcbabo Jul 23, 2012 9:09 PM (in response to igarashitm)

Thanks for putting this together, Tomo. I think this is a great way to capture the various scenarios.

Added #s to your table for reference. I'm not sure what is meant by "Transaction Provided" in this table. Does this mean a transaction already exists, will exist after being created, ...? I'm going to ignore that and just comment on the result field.

For #3, we can create a transaction if the implementation policy is specified and keep the existing behavior if it's absent. That will keep things backward compatible and spec compatible. IINM, this also eliminates the need for 5-7.

#	Interaction Policy	Implementation Policy	Transaction Provided	Result
1	<absent>	<any>	<any>	Propagates transaction if exists, otherwise does nothing
2	propagatesTransaction	managedTransaction.global or <absent>	yes	Propagates transaction
3	propagatesTransaction	managedTransaction.global or <absent>	no	Raise an error (unlike spec)
4	propagatesTransaction	managedTransaction.local or noManagedTransaction	<any>	Raise an error
5	propagatesOrCreatesTransaction	managedTransaction.global or <absent>	yes	Propagates transaction
6	propagatesOrCreatesTransaction	managedTransaction.global or <absent>	no	Creates new transaction, and completes it after invocation
7	propagatesOrCreatesTransaction	managedTransaction.local or noManagedTransaction	<any>	Raise an error
8	suspendsTransaction	managedTransaction.global	yes	Suspends existing transaction and creates new one. After invocation, complete the transaction created, and then resume the original transaction
9	suspendsTransaction	managedTransaction.global	no	Creates new transaction, and completes it after invocation
10	suspendsTransaction	managedTransaction.local	yes	Suspends existing transaction and creates new one. After invocation, complete the transaction created, and then resume the original transaction
11	suspendsTransaction	managedTransaction.local	no	Creates new transaction, and completes it after invocation
12	suspendsTransaction	noManagedTransaction or <absent>	yes	Suspends existing transaction and resumes it after invocation
13	suspendsTransaction	noManagedTransaction or <absent>	no	Does nothing

2. Re: Transaction Policy: Stage2

igarashitm Jul 23, 2012 9:46 PM (in response to kcbabo)

Thanks Keith,

I'm not sure what is meant by "Transaction Provided" in this table. Does this mean a transaction already exists, will exist after being created, ...? I'm going to ignore that and just comment on the result field.

I meant the transaction exists before TransactionHandler creates.

For #3, we can create a transaction if the implementation policy is specified and keep the existing behavior if it's absent. That will keep things backward compatible and spec compatible. IINM, this also eliminates the need for 5-7.

That's great idea! updated the table.

#	Interaction Policy	Implementation Policy	Transaction Exists	Result
1	<absent>	<any>	yes	Propagates transaction
2	<absent>	<any>	no	does nothing
3	propagatesTransaction	<absent>	yes	Propagates transaction
4	propagatesTransaction	<absent>	no	Raise an error
5	propagatesTransaction	managedTransaction.global	yes	Propagates transaction
6	propagatesTransaction	managedTransaction.global	no	TransactionHandler creates new transaction, and completes it after invocation
7	propagatesTransaction	managedTransaction.local or noManagedTransaction	<any>	Raise an error
8	suspendsTransaction	managedTransaction.global	yes	TransactionHandler suspends existing transaction and creates new one. After invocation, complete the transaction created, and then resume the original transaction
9	suspendsTransaction	managedTransaction.global	no	TransactionHandler creates new transaction, and completes it after invocation
10	suspendsTransaction	managedTransaction.local	yes	TransactionHandler suspends existing transaction and creates new one. After invocation, complete the transaction created, and then resume the original transaction
11	suspendsTransaction	managedTransaction.local	no	TransactionHandler creates new transaction, and completes it after invocation
12	suspendsTransaction	noManagedTransaction or <absent>	yes	TransactionHandler suspends existing transaction and resumes it after invocation
13	suspendsTransaction	noManagedTransaction or <absent>	no	Does nothing

Obviously better than before

Go to original post