4 Replies Latest reply: Aug 8, 2011 5:20 AM by Andrew Dinn RSS

BYTEMAN-168, ThreadHistoryMonitorHelper

Scott Stark Master

Do you see any problem with comitting this new sample helper class I talk about in this (in progress) article?

http://community.jboss.org/wiki/TrackingThreadsInJBossAS7

  • 1. Re: BYTEMAN-168, ThreadHistoryMonitorHelper
    Andrew Dinn Master

    Hi Scott,

    Scott Stark wrote:

     

    Do you see any problem with comitting this new sample helper class I talk about in this (in progress) article?

    http://community.jboss.org/wiki/TrackingThreadsInJBossAS7

    Thank you very much for the contribution. As far as the code goes I wil be very pleased to integrate this into the sample library. However committing it will require some changes to the previous routine -- luckily, you caught me just as I have effectively completed the process of hopping from svn to git and from ant to maven.

     

    The new git master repo is currently located at

     

      https://github.com/adinn/byteman

     

    It contains two all the release branches as git branches (including your BYTEMAN-148 branch) plus all the release tags as git tags. It also contains your BYTEMAN-148 branch. The svn trunk used to tag the 1.5.2 release has become the new master branch. It might be better if we actually had a byteman repo separate from my own repo but this will be ok for starters.

     

    Yesterday I pushed a new branch called mavenize which is derived from master. It contains all the changes needed to fully mavenize the build process (I snagged the remaiing problems this mornign so I think it is now ready to go). I will merge this into master very soon, probably today.

     

    So, in order to add your sample code to the next release then either i) I can merge the patches supplied in the tracking article into my master repo or ii) you can clone my repo and add your patches then point me at the relevant commit and I will merge them into the master. Your choice.

  • 2. Re: BYTEMAN-168, ThreadHistoryMonitorHelper
    Scott Stark Master

    No problem. I'll clone the new git repo and add the helper so that I'll have my byteman workspace up to date with what the project is using.

  • 3. Re: BYTEMAN-168, ThreadHistoryMonitorHelper
    Scott Stark Master

    The pull request to merge the addition is https://github.com/adinn/byteman/pull/2

  • 4. Re: BYTEMAN-168, ThreadHistoryMonitorHelper
    Andrew Dinn Master

    Thanks very much Scott. Your contribution has been merged and wil appear in the next release.

     

    regards,

     

     

    Andrew Dinn