-
45. Possible Deadlock Sending to JMS Queue
hosier.david Apr 27, 2011 10:45 PM (in response to clebert.suconic)Ok, thanks for sticking with this Clebert and Bill. This was critical for me, so it's greatly appreciated. I have built and ran my tests with your changes, and everything works as desired.
-
46. Possible Deadlock Sending to JMS Queue
clebert.suconic Apr 27, 2011 10:49 PM (in response to hosier.david)BTW: You've made me install node.js
That's kind of a cool tech that I will have to get used :-), and I also used the time to get used to the Bill's code on rest.. so it was everything good in the end :-)
Thanks for testing it and raising the issues. It's great to work on open source at these times where everyone can collaborate to the code.
-
47. Possible Deadlock Sending to JMS Queue
hosier.david Apr 27, 2011 11:23 PM (in response to clebert.suconic)Yeah, node.js is pretty cool stuff. It's really easy to use for testing stuff. I have a node script that I use as an endpoint to test this scenario that we've been testing as well. It creates the subscription and has the messages sent to itself. You should definitely check out the GitHub page that lists all the modules you can install for Node using npm. It's pretty mindblowing the breadth of what's out there. Although Bill had to slap someone's hand because they created a node.js REST testing framework called RESTeasy, which they had to rename. Anyway, thanks again.
-
48. Possible Deadlock Sending to JMS Queue
bill.burke Apr 27, 2011 11:26 PM (in response to hosier.david)Crap man, I didn't know it would be transacted. I'm going to have to review my code a bit. Clebert, this is a blocker bug that we'll need to rev rest interface on. I thought autoAck meant that a success return from onMessage() would ack the message.
-
49. Possible Deadlock Sending to JMS Queue
clebert.suconic Apr 28, 2011 12:07 AM (in response to bill.burke)We can easily release the rest module alone now. A full release would take a while as we are still validating release scripts.
-
50. Possible Deadlock Sending to JMS Queue
clebert.suconic Apr 28, 2011 11:50 AM (in response to bill.burke)hmmmm... this is broken .. it will ack even with a failure
-
51. Possible Deadlock Sending to JMS Queue
hosier.david Apr 28, 2011 12:08 PM (in response to clebert.suconic)Ah, good point. I think that makes the case for explicitly calling session.commit() in the if (acknowledge) block.
-
52. Possible Deadlock Sending to JMS Queue
clebert.suconic Apr 28, 2011 12:36 PM (in response to hosier.david)Or rollback.
-
53. Possible Deadlock Sending to JMS Queue
clebert.suconic Apr 28, 2011 12:37 PM (in response to clebert.suconic)I mean in case of a failure :->> rollback
-
54. Possible Deadlock Sending to JMS Queue
bill.burke Apr 29, 2011 12:44 PM (in response to clebert.suconic)How come the onMessage() invoker doesn't commit the session?
-
55. Possible Deadlock Sending to JMS Queue
clebert.suconic Apr 29, 2011 12:49 PM (in response to bill.burke)The core API is at a low level. You have to commit it yourself.
It's not like the JMS Listener where you have auto-ack.. etc.
-
56. Possible Deadlock Sending to JMS Queue
bill.burke May 9, 2011 8:21 AM (in response to clebert.suconic)I sat down with Clebert last week and we fixed the code. I created a branch:
https://svn.jboss.org/repos/hornetq/branches/Branch_2_2_2_REST
merged from trunk, and released into our maven repository.
You can pick up the changes by switching your hornetq-rest libraries to "2.2.2.1" version.
-
57. Possible Deadlock Sending to JMS Queue
hosier.david May 9, 2011 9:20 PM (in response to bill.burke)Ok, I think the pom is broken for org.hornetq.rest#hornetq-rest. Granted, I'm using Ivy instead of Maven, and I don't know much about pom files, but the parent is marked as being hornetq-rest-all v.2.2.2.1, and there is no such version of hornetq-rest-all in the JBoss maven repository. So my build fails to grab hornetq-rest due to this if I understand what Ivy is telling me. Or am I missing something?
-
58. Possible Deadlock Sending to JMS Queue
bill.burke May 12, 2011 8:14 AM (in response to hosier.david)Apologies, I screwed up the poms (and the repository for 2.2.2.1).
Use version 2.2.2.2 for hornetq-rest now.
-
59. Re: Possible Deadlock Sending to JMS Queue
jamshed.katta Jun 20, 2011 1:58 AM (in response to hosier.david)Hello David,
Could you please giude me on how to add latest hornet rest to Jboss6 Final
and are there compatibility problems with other libraries?
Regards.