0 Replies Latest reply on Feb 22, 2011 1:27 PM by lincolnthree

    SHRINKDESC-21 and SHRINKDESC-33

    lincolnthree

      I've begun work and am seeking review on:

       

      https://issues.jboss.org/browse/SHRINKDESC-21

      https://issues.jboss.org/browse/SHRINKDESC-33

       

      https://github.com/lincolnthree/shrinkwrap-descriptors/commit/4e14677e0e8cc8e86e1b1292cfead61e0c1b7e35\

      https://github.com/lincolnthree/shrinkwrap-descriptors/commit/bb1f359c91708044f7c41c6c0b9bc18702e01bef

       

      Currently I have simply extended the existing interfaces, and followed the same design patterns that were already being used, but ALR and I had discussed migrating to a Mutable/Immutable type relationship for descriptors.

       

      WebAppDescriptor would be read-only.

      MutableWebAppDescriptor would include the builder-methods to update, add, and remove data.

       

      Thoughts?

       

      Going to send a pull-request soon.