JBossRetro weaver issues| JBoss.org Content Archive (Read Only)

60. Re: JBossRetro weaver issues

adrian.brock Mar 20, 2006 10:04 AM (in response to starksm64)

"ryan.campbell@jboss.com" wrote:
I went ahead and checked this in. You can run it with
cd webservices; ant clean main -Dretro=true

What is the purpose of defining a system property rather than
using a specific ant target?

e.g.
ant clean main retro

61. Re: JBossRetro weaver issues

ryan.campbell Mar 20, 2006 12:24 PM (in response to starksm64)

What is the purpose of defining a system property rather than
using a specific ant target?

Well, there is a jbossretro target, but the retro flag is used throughout the webservices build file to determine which jars to build & deploy. I chose to retain the existing approach and just remove the usage of retrotranslator. There is some further cleanup needed there, but requires more discussion with the webservices team.

62. Re: JBossRetro weaver issues

ryan.campbell Mar 27, 2006 7:08 PM (in response to starksm64)

Regarding the changes made to javassist: are any of them exercised at runtime? ie, could we possibly leave javaassist at 3.1RC2 in jboss-4.0?

63. Re: JBossRetro weaver issues

ryan.campbell Mar 27, 2006 7:37 PM (in response to starksm64)

FYI, I committed this to the component-info for jbossretro:

 + <!-- JBossRetro requires javassist 3.2.0.CR1 at weave time -->
 + <!-- but seems to be compatible with 3.1RC2 at runtime based on testsuite runs -->
 <import componentref="javassist">
 + <compatible version="3.1RC2"/>
 <compatible version="3.2.0.CR1"/>
 </import>

If the above cannot hold, AOP will need to be updated to deal with javassist 3.2.0.CR1

64. Re: JBossRetro weaver issues

starksm64 Mar 27, 2006 7:47 PM (in response to starksm64)

"ryan.campbell@jboss.com" wrote:
Regarding the changes made to javassist: are any of them exercised at runtime? ie, could we possibly leave javaassist at 3.1RC2 in jboss-4.0?

No, the jbossretro requires javassist 3.2.0.CR1. jbossretro should not be marked as compatible with 3.1RC2 because of the annotation changes Adrian made.

aop 1.3.4 is definitely not compatible with javassist 3.2.0.CR1. The current jboss-head code for FieldAccessTransformer looks nothing like 1.3.x.

65. Re: JBossRetro weaver issues

starksm64 Mar 27, 2006 10:30 PM (in response to starksm64)

I have built a jboss-aop jar against the javassist 3.2.0.CR1 version using the JBoss_Aop_1_3_5 tagged aop source. Using the resulting jboss-aop.jar allows the testsuite to build using javassit 3.2.0.CR1. There are a few aop module unit tests that are failing so its not clear these are really compatible:

Testsuite: org.jboss.test.aop.annotated.AnnotatedTestCase
Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 1.64 sec
Testsuite: org.jboss.test.aop.annotatedparams.AnnotatedParamsTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.344 sec
Testsuite: org.jboss.test.aop.annotationc.AnnotationTester
Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 0.219 sec
Testsuite: org.jboss.test.aop.args.ArgsTestCase
Tests run: 3, Failures: 0, Errors: 3, Time elapsed: 0.438 sec

Testcase: testBench took 0.438 sec
 Caused an ERROR
null
java.lang.ExceptionInInitializerError
 at org.jboss.test.aop.args.ArgsTestCase.testBench(Unknown Source)
Caused by: java.lang.RuntimeException: javassist.CannotCompileException: [source error] no such class: org.jboss.test.aop.args.POJO.bunchArgs_N5735936556171587907
 at org.jboss.aop.advice.AdviceFactory.create(Unknown Source)
 at org.jboss.aop.Advisor.createInterceptorChain(Unknown Source)
 at org.jboss.aop.Advisor.resolveMethodPointcut(Unknown Source)
 at org.jboss.aop.ClassAdvisor.createInterceptorChains(Unknown Source)
 at org.jboss.aop.ClassAdvisor$1.run(Unknown Source)
 at java.security.AccessController.doPrivileged(Native Method)
 at org.jboss.aop.ClassAdvisor.attachClass(Unknown Source)
 at org.jboss.aop.AspectManager.getAdvisor(Unknown Source)
 at org.jboss.test.aop.args.POJO.<clinit>(Unknown Source)
 ... 18 more
Caused by: javassist.CannotCompileException: [source error] no such class: org.jboss.test.aop.args.POJO.bunchArgs_N5735936556171587907
 at javassist.CtNewMethod.make(CtNewMethod.java:78)
 at javassist.CtNewMethod.make(CtNewMethod.java:44)
 at org.jboss.aop.advice.PerVmAdvice.generateArgsInterceptor(Unknown Source)
 at org.jboss.aop.advice.PerVmAdvice.generateInterceptor(Unknown Source)
 at org.jboss.aop.advice.PerVmAdvice.generateOptimized(Unknown Source)
 ... 27 more
Caused by: compile error: no such class: org.jboss.test.aop.args.POJO.bunchArgs_N5735936556171587907
 at javassist.compiler.MemberResolver.searchImports(MemberResolver.java:406)
 at javassist.compiler.MemberResolver.lookupClass(MemberResolver.java:382)
 at javassist.compiler.MemberResolver.lookupClassByJvmName(MemberResolver.java:310)
 at javassist.compiler.MemberResolver.resolveJvmClassName(MemberResolver.java:450)
 at javassist.compiler.MemberCodeGen.resolveClassName(MemberCodeGen.java:1064)
 at javassist.compiler.CodeGen.atDeclarator(CodeGen.java:698)
 at javassist.compiler.ast.Declarator.accept(Declarator.java:99)
 at javassist.compiler.CodeGen.atStmnt(CodeGen.java:344)
 at javassist.compiler.ast.Stmnt.accept(Stmnt.java:49)
 at javassist.compiler.CodeGen.atStmnt(CodeGen.java:344)
 at javassist.compiler.ast.Stmnt.accept(Stmnt.java:49)
 at javassist.compiler.CodeGen.atMethodBody(CodeGen.java:285)
 at javassist.compiler.CodeGen.atMethodDecl(CodeGen.java:267)
 at javassist.compiler.ast.MethodDecl.accept(MethodDecl.java:43)
 at javassist.compiler.Javac.compileMethod(Javac.java:158)
 at javassist.compiler.Javac.compile(Javac.java:93)
 at javassist.CtNewMethod.make(CtNewMethod.java:73)
 ... 31 more

Testsuite: org.jboss.test.aop.basic.AOPTester
Tests run: 17, Failures: 0, Errors: 0, Time elapsed: 1.109 sec
Testsuite: org.jboss.test.aop.beanstyleconfig.ConfigTester
Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.563 sec
Testsuite: org.jboss.test.aop.callerscope.CallerScopeTestCase
Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 0.078 sec
Testsuite: org.jboss.test.aop.construction.ConstructionTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.172 sec
Testsuite: org.jboss.test.aop.constructortarget.ConstructorTargetTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.032 sec
Testsuite: org.jboss.test.aop.dotinpointcutname.DotInPointcutNameTestCase
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.219 sec
Testsuite: org.jboss.test.aop.implementz.ImplementsTester
Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.5 sec
Testsuite: org.jboss.test.aop.instanceofannotated.InstanceOfAnnotatedTester
Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.047 sec
Testsuite: org.jboss.test.aop.introduction.IntroductionTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.219 sec
Testsuite: org.jboss.test.aop.override.OverrideTestCase
Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.297 sec
Testsuite: org.jboss.test.aop.perjoinpoint.PerJoinpointTester
Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 18 sec
Testsuite: org.jboss.test.aop.precedence.PrecedenceTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.484 sec
Testsuite: org.jboss.test.aop.reflection.ReflectionTester
Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 1.609 sec
Testsuite: org.jboss.test.aop.regression.annotatedIntroduction.AOPTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.141 sec
Testsuite: org.jboss.test.aop.regression.arraymethodparam.ArrayMethodParamTestCase
Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.203 sec
Testsuite: org.jboss.test.aop.regression.ejbthree315.UnderscoreMethodTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.172 sec
Testsuite: org.jboss.test.aop.regression.inheritedfield.InheritedFieldTestCase
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.172 sec
Testsuite: org.jboss.test.aop.regression.inheritedmcall.AOPTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.187 sec
Testsuite: org.jboss.test.aop.regression.statictest.AOPTester
Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.203 sec

66. Re: JBossRetro weaver issues

kabirkhan Mar 28, 2006 7:15 AM (in response to starksm64)

I am in the process of upgrading jboss aop.

http://jira.jboss.com/jira/browse/JBAS-3017

The test you mention is a known issue, it cannot and will not work in that weaving mode, so I have removed it

67. Re: JBossRetro weaver issues

adrian.brock Apr 4, 2006 7:26 AM (in response to starksm64)

I've added a WIKI page:
http://wiki.jboss.org/wiki/Wiki.jsp?page=JBossRetro