-
1. Re: Comments on overlord-cdl-1.0-M1 Trailblazer example
objectiser Jan 6, 2009 5:23 PM (in response to jeffdelong)Good points.
We originally built upon the trailblazer example in the JBossESB distribution - so tried to just add further documentation around the documentation provided as part of that project. However I understand that this trailblazer sample is now being dropped from the JBossESB distribution, so I think it will be easier for us to take over the complete documentation for this sample and add more 'cdl' relevant details to it.
I agree - there should be one jboss-esb.xml per service. This is how the services are generated from a choreography. If we are now taking over the trailblazer example, then it will be easier to update it to separate the services into different config files.
Regards
Gary -
2. Re: Comments on overlord-cdl-1.0-M1 Trailblazer example
jeffdelong Jan 6, 2009 7:49 PM (in response to jeffdelong)A few suggestions on how to improve the documentation:
1) Have the readme refer to the docs/samplesguide/SamplesGuide. While much of the information is redundant, the SamplesGuides has the information on the ChoreographyMonitor and the error-client.
2) In the SamplesGuide.pdf, the code snippet from LoanBroker.java is unreadable.
3) Under 10 2 It says to run the commands from step 6 on. Is that really necessary?
4) Add more information on the role of the LoanBroker.java class, and how it's choice of
if (score >= 4) {
//step 3a - send to Bank - async
System.out.println("sending to first Bank...");
sendToBank(bank1Invoker, customer, "b1");
Implements the Choreography conditional expression: cdl:getVariable('creditCheckResult','','//@score') >= 4
5) It would be nice to have an architectural discussion here about how this choreography is being monitored. (perhaps this is described in another document I have yet to read).
Thanks,
Jeff