-
15. Re: Breaking up the MC project and Mavenizing it
I added assemblies for aop-mc-int and dependency. Please take a look, and if it is ok I will do the same thing for the other subprojects.
Once deployed, other projects can use these artifacts using a classifier. So a dependency on aop-mc-int-aspects would look like this:<dependency> <groupId>jboss</groupId> <artifactId>jboss-aop-mc-int</artifactId> <version>2.0</version> <classifier>aspects</classifier> </dependency>
-
16. Re: Breaking up the MC project and Mavenizing it
We have a funny package structure:
org.jboss.dependency.plugins.spi.action.ControllerContextAction
Perhaps we could move this out of plugins into org.jboss.dependency.spi.action? -
17. Re: Breaking up the MC project and Mavenizing it
I did a regular expression check: plugins.[a-z\.]*spi
This is the only such plugins and spi combination.
I'm really in favor of moving this.
But we need to fix that in the AS as well, with ServiceControllerContextAction(s).
When would be an appropriate time to do that - to update the mc snapshot used with AS trunk as well? -
18. Re: Breaking up the MC project and Mavenizing it
"alesj" wrote:
We have a funny package structure:
org.jboss.dependency.plugins.spi.action.ControllerContextAction
Perhaps we could move this out of plugins into org.jboss.dependency.spi.action?
I could change the assembly to put this package with the spi assembly instead of the plugins. But I think you're right that this should be moved. -
19. Re: Breaking up the MC project and Mavenizing it
"alesj" wrote:
We have a funny package structure:
org.jboss.dependency.plugins.spi.action.ControllerContextAction
Perhaps we could move this out of plugins into org.jboss.dependency.spi.action?
Nothing wrong with that. :-)
It is a spi for one possible implementation choice.
You're not forced to use that implementation so it doesn't belong in the global spi.
javaee has a spi and so does JBoss (one possible implementation choice),
but you wouldn't dream of adding JBoss spi into the javax.* javaee packages. -
20. Re: Breaking up the MC project and Mavenizing it
"alesj" wrote:
I did a regular expression check: plugins.[a-z\.]*spi
This is the only such plugins and spi combination.
I'm really in favor of moving this.
But we need to fix that in the AS as well, with ServiceControllerContextAction(s).
When would be an appropriate time to do that - to update the mc snapshot used with AS trunk as well?
The AS trunk cannot be updated until after the beta2 release next week. Right now its using the 2_0 branch of the mc. We either need to merge or replace the 2_0 branch with the mc trunk. -
21. Re: Breaking up the MC project and Mavenizing it
"adrian@jboss.org" wrote:
"alesj" wrote:
We have a funny package structure:
org.jboss.dependency.plugins.spi.action.ControllerContextAction
Perhaps we could move this out of plugins into org.jboss.dependency.spi.action?
Nothing wrong with that. :-)
It is a spi for one possible implementation choice.
You're not forced to use that implementation so it doesn't belong in the global spi.
I would still move it into global spi.
Even though you are not forced to use it.
Or maybe it shouldn't be called spi.
api as in metatype/managed?"adrian@jboss.org" wrote:
javaee has a spi and so does JBoss (one possible implementation choice),
but you wouldn't dream of adding JBoss spi into the javax.* javaee packages.
Why not? :-) -
22. Re: Breaking up the MC project and Mavenizing it
"scott.stark@jboss.org" wrote:
The AS trunk cannot be updated until after the beta2 release next week. Right now its using the 2_0 branch of the mc. We either need to merge or replace the 2_0 branch with the mc trunk.
Ok, I'll wait.
And 'persuade' Adrian next week to push this into more appropriate place. ;-)