3 Replies Latest reply on Sep 8, 2011 3:01 AM by rbattenfeld

ARQ-148 Support EL-like expressions for sysprops and env variables in arquillian.xml

rbattenfeld Sep 4, 2011 8:24 AM

Hi Aslak, Andrew and Karel

I worked a little bit on this task. I implemented a version using the StringPropertyReplacer as used in JBoss for this kind of jobs. Basically, it works at least for system properties. For going further, I'd like to ask some questions:

Is it ok for you that arquillian-container-impl-base has a dependency to the jboss-common-core.jar library?
Aslak suggested to implement it in both existing MapObject's. Does this cover all arquillian.xml elements and attributes?
The original JIRA from Andrew describes support for JSF EL features. Shall we implement it in two steps? First the system props replacement and afterwards support for such EL expressions? Andrew and Aslak, what do you think?
Which arquillian-core branch is the right one? Master?

My repo for this JIRA is: https://github.com/rbattenfeld/arquillian-core/tree/ARQ-148

Thanks

Ralf

1. Re: ARQ-148 Support EL-like expressions for sysprops and env variables in arquillian.xml

kpiwko Sep 5, 2011 3:41 AM (in response to rbattenfeld)

Hi Ralf,

1. IMHO introducing an extra dependency should be avoided. Isn't there a way how to copy required functionality into Arquillian? I checked the code of SpringPropertyReplacer and it doesn't seem to have any external dependency.
2. No, it won't. MapObject is used to populate only Container/Container Protocol related configuration. There are plenty of others' such as extension, group, engine, etc. I think this should be implemented directly in config/impl-base so all arquillian.xml elements will be transparently enriched by System properties.
3. Yes, we'll definitely implement this in two steps.
4. Yes, master is the correct branch.

Thanks for the initial implementation!

Karel
Actions
2. Re: ARQ-148 Support EL-like expressions for sysprops and env variables in arquillian.xml

rbattenfeld Sep 5, 2011 11:17 AM (in response to kpiwko)

Thanks Karel

I will proceed as you have suggested.

Regards,
Ralf
Actions
3. Re: ARQ-148 Support EL-like expressions for sysprops and env variables in arquillian.xml

rbattenfeld Sep 8, 2011 3:01 AM (in response to rbattenfeld)

Hi Andrew, Aslak and Karel

Please have a look at: https://github.com/rbattenfeld/arquillian-core/tree/ARQ-148

I sent aslak a pull request in order to have a preview on ARQ-148. I will finish this over the weekend.

Regards,
Ralf
Actions

Go to original post